From 0f2c863e4e4f30355ce06450921f077340a96f04 Mon Sep 17 00:00:00 2001
From: Bob Mottram <bob@freedombone.net>
Date: Mon, 30 Sep 2019 11:35:49 +0100
Subject: [PATCH] Check that number of tags is not too large

---
 inbox.py | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/inbox.py b/inbox.py
index e8be76d04..d9ea5eee3 100644
--- a/inbox.py
+++ b/inbox.py
@@ -1110,6 +1110,7 @@ def validPostContent(messageJson: {},maxMentions: int) -> bool:
     """Is the content of a received post valid?
     Check for bad html
     Check for hellthreads
+    Check number of tags is reasonable
     """
     if not messageJson.get('object'):
         return True
@@ -1117,16 +1118,24 @@ def validPostContent(messageJson: {},maxMentions: int) -> bool:
         return True
     if not messageJson['object'].get('content'):
         return True
-    invalidStrings=['<script>','<style>','</html>','</body>','<br>','<hr>']
+    # check for bad html
+    invalidStrings=['<script>','<style>','</html>','</body>','<br>','<hr>']    
     for badStr in invalidStrings:
         if badStr in messageJson['object']['content']:
             if messageJson['object'].get('id'):
                 print('REJECT: '+messageJson['object']['id'])
             print('REJECT: bad string in post - '+messageJson['object']['content'])
             return False
+    # check (rough) number of mentions
     if estimateNumberOfMentions(messageJson['object']['content'])>maxMentions:
         print('REJECT: Too many mentions in post - '+messageJson['object']['content'])
         return False
+    # check number of tags
+    if messageJson['object'].get('tag'):
+        if isinstance(messageJson['object']['tag'], list):
+            if len(messageJson['object']['tag'])>maxMentions*2:
+                print('REJECT: Too many tags in post - '+messageJson['object']['tag'])
+                return False
     print('ACCEPT: post content is valid')
     return True